[ https://issues.apache.org/jira/browse/LUCENE-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283725#comment-13283725 ]
Andrzej Bialecki commented on LUCENE-4055: ------------------------------------------- +1, this looks very good. One comment re. SegmentInfoPerCommit. This class is not extensible and contains a fixed set of attributes. In LUCENE-3837 this or similar place would be the ideal mechanism to carry info about stacked segments, since this information is specific to a commit point. Unfortunately, there are no Map<String,String> attributes on this level, so I guess for now this type of aux data will have to be put in SegmentInfos.userData even though it's not index global but segment-specific. > Refactor SegmentInfo / FieldInfo to make them extensible > -------------------------------------------------------- > > Key: LUCENE-4055 > URL: https://issues.apache.org/jira/browse/LUCENE-4055 > Project: Lucene - Java > Issue Type: Improvement > Components: core/codecs > Reporter: Andrzej Bialecki > Assignee: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-4055.patch > > > After LUCENE-4050 is done the resulting SegmentInfo / FieldInfo classes > should be made abstract so that they can be extended by Codec-s. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org