[ 
https://issues.apache.org/jira/browse/SOLR-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291637#comment-13291637
 ] 

Robert Muir commented on SOLR-3520:
-----------------------------------

+1

its dangerous when these don't have tests, there could be very simple bugs or 
patches in the future that break things
and we won't notice.

we should also keep an eye on 
https://builds.apache.org/job/Solr-trunk/clover/org/apache/solr/analysis/pkg-summary.html
which makes it very easy to see which ones are missing tests.
                
> Add missing tests for JapaneseReadingFormFilterFactory and 
> JapaneseKatakanaStemFilterFactory
> --------------------------------------------------------------------------------------------
>
>                 Key: SOLR-3520
>                 URL: https://issues.apache.org/jira/browse/SOLR-3520
>             Project: Solr
>          Issue Type: Test
>    Affects Versions: 4.0, 5.0
>            Reporter: Christian Moen
>            Priority: Minor
>         Attachments: SOLR-3520.patch
>
>
> {{JapaneseReadingFormFilterFactory}} and 
> {{JapaneseKatakanaStemFilterFactory}} doesn't have any tests and it would be 
> good to have some.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to