[
https://issues.apache.org/jira/browse/SOLR-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-3535:
-----------------------------------
Attachment: SOLR-3535.patch
new attach highlights:
* UpdReqProc.processAdd() become protected
* FlattenerUpdateProcessorFactory has been introduced.
* it transforms the given SolrInputDocument with nested subdocs into block of
SIDs
* i.e. it transforms AddUpdCmd to AddBlockUpdCmd
* nested subdocs are placed as collection of SID fields. Hoss, excuse me. It's
not really my point - we can later switch to getChildrenDocs(). it just seems
to me easier for now. Let's polish it later.
* you can see that Flattener is placed between Distributed and Log/Run. i.e. I
addressed your guys point - make it compatible with distributed update magic.
* forgot to cover tree levels of nesting, my falut. it's trivial transitive
closure via recursion. I'll switch to iteration further.
* XMLLoader supports <field
name="skills"><doc>..</doc><doc>..</doc><doc>..</doc><doc>..</doc></field> it's
a nested docs.
* there are tests, puzzling a little. test harness is harmed a little.
Please have a look, and raise your concerns!
btw it might be easier https://github.com/m-khl/solr-patches/commits/blockupdate
> Add block support for XMLLoader
> -------------------------------
>
> Key: SOLR-3535
> URL: https://issues.apache.org/jira/browse/SOLR-3535
> Project: Solr
> Issue Type: Sub-task
> Components: update
> Affects Versions: 4.1, 5.0
> Reporter: Mikhail Khludnev
> Priority: Minor
> Attachments: SOLR-3535.patch, SOLR-3535.patch
>
>
> I'd like to add the following update xml message:
> <add-block>
> <doc>....</doc>
> <doc>....</doc>
> </add-block>
> out of scope for now:
> * other update formats
> * update log support (NRT), should not be a big deal
> * overwrite feature support for block updates - it's more complicated, I'll
> tell you why
> Alt
> * wdyt about adding attribute to the current tag {pre}<add block="true">{pre}
> * or we can establish RunBlockUpdateProcessor which treat every <add>
> ....</add> as a block.
> *Test is included!!*
> How you'd suggest to improve the patch?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
