On Tue, Jun 19, 2012 at 6:13 PM, Michael McCandless <[email protected]> wrote: > Ahhh good point: using the annotation, LuceneTestCase will simply pick > a codec that's allowed, and the test runs. > > But using an Assume somewhere inside means ... LuceneTestCase can pick > the "wrong" codec and then silently the test doesn't run. > > And, I hadn't realized I can add the annot to BaseTokenStreamTestCase > and all tests inheriting from it will respect that. Though I guess > that means any test inheriting from BTSTC and not using > checkRandomData with biggish args loses some test coverage ... but > that seems the lesser evil here. >
Looking at your commit, i fixed it with a different approach: if your logic doesn't match, we just dont index anything (but still test the actual analyzer). -- lucidimagination.com --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
