[ https://issues.apache.org/jira/browse/LUCENE-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401312#comment-13401312 ]
Torsten Krah edited comment on LUCENE-4165 at 6/26/12 11:46 AM: ---------------------------------------------------------------- Just did think about it again and would prefer to close the readers explicitly too. A Reader may internally acquire other resources (byte buffers etc.) which must/should be released too (e.g. have a look at: com.sun.org.apache.xerces.internal.impl.io.UTF8Reader). Calling close() on the reader should imho be done too - do you agree with me? was (Author: tkrah): Just did think about it again and would prefer to close the readers explicitly too. A Reader may internally acquire other resources (byte buffers etc.) which must/should be released too. Calling close() on the reader should imho be done too - do you agree with me? > HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed > ------------------------------------------------------------------------------ > > Key: LUCENE-4165 > URL: https://issues.apache.org/jira/browse/LUCENE-4165 > Project: Lucene - Java > Issue Type: Bug > Components: modules/analysis > Affects Versions: 3.6 > Environment: Linux, Java 1.6 > Reporter: Torsten Krah > Priority: Minor > Attachments: lucene_36.patch, lucene_trunk.patch > > > The HunspellDictionary takes an InputStream for affix file and a List of > Streams for dictionaries. > Javadoc is not clear about i have to close those stream myself or the > Dictionary constructor does this already. > Looking at the code, at least reader.close() is called when the affix file is > read via readAffixFile() method (although closing streams is not done in a > finally block - so the constructor may fail to do so). > The readDictionaryFile() method does miss the call to close the reader in > contrast to readAffixFile(). > So the question here is - have i have to close the streams myself after > instantiating the dictionary? > Or is the close call only missing for the dictionary streams? > Either way, please add the close calls in a safe manner or clarify javadoc so > i have to do this myself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org