Chris Male created LUCENE-4166:
----------------------------------

             Summary: TwoDoublesStrategy is broken for Circles
                 Key: LUCENE-4166
                 URL: https://issues.apache.org/jira/browse/LUCENE-4166
             Project: Lucene - Java
          Issue Type: Bug
          Components: modules/spatial
            Reporter: Chris Male
            Priority: Critical


TwoDoublesStrategy supports finding Documents that are within a Circle, yet it 
is impossible to provide one due to the following code found at the start of 
TwoDoublesStrategy.makeQuery():

{code}
Shape shape = args.getShape();
    if (!(shape instanceof Rectangle)) {
      throw new InvalidShapeException("A rectangle is the only supported shape 
(so far), not "+shape.getClass());//TODO
    }
    Rectangle bbox = (Rectangle) shape;
{code}

I think instead the code which handles Circles should ask for the bounding box 
of the Shape and uses that instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to