[ 
https://issues.apache.org/jira/browse/SOLR-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402851#comment-13402851
 ] 

Trym Møller edited comment on SOLR-3582 at 6/28/12 5:13 AM:
------------------------------------------------------------

Debugging the provided test shows this behaviour as well, that is, the Watch is 
kept even though, its notified about disConnection and syncConnection and the 
Watch will first "stop" after it has been notified about a node change.

As Mark writes on the mailing list, there might be other ZooKeeper Watchers in 
Solr which might add new watchers on reconnect.

If we agree about the ZooKeeper watcher behaviour, then I think that the 
provided bug fix solves the problem in the LeaderElector and it can be 
committed to svn independently of problems with other watchers. Are there other 
things I can do to show, that the provided solution is the right one?

Best regards Trym
                
      was (Author: trym):
    Debugging the provided test shows this behaviour as well, that is, the 
Watch is kept even though, its notified about disConnection and syncConnection 
and the Watch will first "stop" after it has been notified about a node change.

As Mark writes on the mailing list, there might be other ZooKeeper Watchers in 
Solr which might add new watchers on reconnect.

If we agree about the ZooKeeper watcher behaviour, then I think that the 
provided bug fix solves the problem in the LeaderElector and it can be 
committed to svn independently of problems with other watchers. Are there other 
things I can do, to show that the solution is the right one?

Best regards Trym
                  
> Leader election zookeeper watcher is responding to con/discon notifications 
> incorrectly.
> ----------------------------------------------------------------------------------------
>
>                 Key: SOLR-3582
>                 URL: https://issues.apache.org/jira/browse/SOLR-3582
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 4.0, 5.0
>
>
> As brought up by Trym R. Møller on the mailing list, we are responding to 
> watcher events about connection/disconnection as if they were notifications 
> about node changes.
> http://www.lucidimagination.com/search/document/e13ef390b88eeee2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to