[ https://issues.apache.org/jira/browse/LUCENE-4157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404910#comment-13404910 ]
David Smiley commented on LUCENE-4157: -------------------------------------- I committed "PortedSolr3Test" which is mostly Solr 3's SpatialFilterTest + a quick sort test I think I found in Solr somewhere. This a parameterized test of RecursivePrefixTreeStrategy & TermQueryPrefixTreeStrategy with Geohash & Quad grids. I deleted TestSpatialPrefixField which didn't test anything -- it was someone's work in progress with no progress. > Improve Spatial Testing > ----------------------- > > Key: LUCENE-4157 > URL: https://issues.apache.org/jira/browse/LUCENE-4157 > Project: Lucene - Java > Issue Type: Improvement > Components: modules/spatial > Reporter: David Smiley > Assignee: David Smiley > Priority: Critical > Fix For: 4.0 > > Attachments: LUCENE-4157_Improve_Lucene_Spatial_testing_p1.patch, > LUCENE-4157_Improve_TermQueryPrefixTreeStrategy_and_move_makeQuery_impl_to_SpatialStrategy.patch > > > Looking back at the tests for the Lucene Spatial Module, they seem > half-baked. (At least Spatial4j is well tested). I've started working on > some improvements: > * Some tests are in an abstract base class which have a subclass that > provides a SpatialContext. The idea was that the same tests could test other > contexts (such as geo vs not or different distance calculators (haversine vs > vincenty) but this can be done using RandomizedTesting's nifty parameterized > test feature, once there is a need to do this. > * Port the complex geohash recursive prefix tree test that was developed on > the Solr side to the Lucene side where it belongs. > And some things are not tested or aren't well tested: > * Distance order as the query score > * Indexing shapes other than points (i.e. shapes with area / regions) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org