[
https://issues.apache.org/jira/browse/LUCENE-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406089#comment-13406089
]
Ryan McKinley commented on LUCENE-4099:
---------------------------------------
This looks fine, it looks like the one impact is that the Strategy would be
instanciated once for each field rather then once for each fieldType (in solr
terms)
> Remove generics from SpatialStrategy and remove SpatialFieldInfo
> ----------------------------------------------------------------
>
> Key: LUCENE-4099
> URL: https://issues.apache.org/jira/browse/LUCENE-4099
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: Chris Male
> Assignee: David Smiley
> Priority: Minor
> Attachments:
> LUCENE-4099_remove_SpatialFieldInfo_and_put_fieldName_into_Strategy_instead_of_methods.patch
>
>
> Same time ago I added SpatialFieldInfo as a way for SpatialStrategys to
> declare what information they needed per request. This meant that a Strategy
> could be used across multiple requests. However it doesn't really need to be
> that way any more, Strategies are light to instantiate and the generics are
> just clumsy and annoying.
> Instead Strategies should just define what they need in their constructor.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
