David Smiley created SOLR-3603:
----------------------------------

             Summary: StreamingResponseCallback could use streamEnd() callback
                 Key: SOLR-3603
                 URL: https://issues.apache.org/jira/browse/SOLR-3603
             Project: Solr
          Issue Type: Improvement
          Components: clients - java
            Reporter: David Smiley
            Priority: Minor


The StreamingResponseCallback API is pretty useful.  There is a callback at the 
beginning, and once for each document.  However there isn't one for the end, 
which I find annoying.  I started to create a bunch of instance variables in my 
anonymous inner class, initialized in streamDocListInfo(), accessed in 
streamSolrDocument().  I needed to close some output streams I am writing to 
but I don't have access to them when it's done.  If there was a callback at the 
end like streamEnd() (with a no-op impl in the abstract class) then I could 
extend it to close the tream I was writing to.  Instead, I have to re-think how 
I've structured this callback.  Do-able of course but annoying.

Sound good?  I'll post a patch if I get an approval to the idea.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to