[
https://issues.apache.org/jira/browse/LUCENE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-4199:
----------------------------------
Attachment: LUCENE-4199.patch
New patch with improvements:
- Use ASM-4.0 with generics support (asm-debug-all)
- Add licence and notice files
- Separte the 2 tasks and make validate task depend on licenses and forbidden
task
- Rename to "forbidden-api". The revised version now supports discouraging
whole classes (FileReader, FileWriter), so not all ctors must be ecplicitely
listed. The ant target only doing the API checks is now "ant
check-forbidden-apis"
I think it's ready to commit, we may only disable some of the classes that are
forbidden until fixed. We may also add option to not fail the build, but warn
only.
> Add ANT tool to track/disallow "forbidden" method invocations
> -------------------------------------------------------------
>
> Key: LUCENE-4199
> URL: https://issues.apache.org/jira/browse/LUCENE-4199
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 4.0-ALPHA
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 4.0
>
> Attachments: LUCENE-4199.patch, LUCENE-4199.patch, LUCENE-4199.patch
>
>
> In LUCENE-3877 Greg Bowyer has some asm.jar-based code to inspe ct class
> files for System.out/err class. I wanted to modify this code to run it in a
> jar-linter task on ant, so all compiled class files are parsed and
> method/ctor calls to e.g. new String(byte[]) without charset are forbidden.
> We would add a list of method signatures that we dont want to have (new
> FileReader(File), commons.IOUtils.loadFileToString()) and this linter will
> throw BuildException after static inspection, if any class file in
> Lucene/Solr (including line numbers) uses any method call.
> Greg's code would be changed to use visitMethodInsn visitor, very easy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
