Yes, ill fix! On Thu, Jul 12, 2012 at 7:25 AM, Uwe Schindler <[email protected]> wrote: > Can you simply fix it for me? > > ----- > Uwe Schindler > H.-H.-Meier-Allee 63, D-28213 Bremen > http://www.thetaphi.de > eMail: [email protected] > > >> -----Original Message----- >> From: Robert Muir [mailto:[email protected]] >> Sent: Thursday, July 12, 2012 1:20 PM >> To: [email protected] >> Subject: Re: svn commit: r1360619 - in /lucene/dev/trunk/lucene: build.xml >> common-build.xml tools/ivy.xml tools/lib/apache-rat-0.8.jar.sha1 >> tools/lib/apache-rat-LICENSE-ASL.txt tools/lib/apache-rat-NOTICE.txt >> >> its not an endless chain of depends, tools/ is not really a real module and >> had >> no dependencies before. >> >> So its excluded from the ordinary modules-crawl (no documentation, javadocs, >> tests, packaging is done for it). >> >> Now it has dependencies, so its important that resolve defer to it if we >> want it >> to work within IDEs such as eclipse, and if we want tasks like jar-checksum >> to >> work. >> >> On Thu, Jul 12, 2012 at 7:11 AM, Uwe Schindler <[email protected]> wrote: >> > Aha - I have no idea what you are talking about. Fix it, for me it works! I >> refuse to add endless chains of depends everywhere just to get a stupid tool >> xy >> working in compination yx on foobar. >> > >> > ----- >> > Uwe Schindler >> > H.-H.-Meier-Allee 63, D-28213 Bremen >> > http://www.thetaphi.de >> > eMail: [email protected] >> > >> > >> >> -----Original Message----- >> >> From: Robert Muir [mailto:[email protected]] >> >> Sent: Thursday, July 12, 2012 1:07 PM >> >> To: [email protected] >> >> Subject: Re: svn commit: r1360619 - in /lucene/dev/trunk/lucene: >> >> build.xml common-build.xml tools/ivy.xml >> >> tools/lib/apache-rat-0.8.jar.sha1 >> >> tools/lib/apache-rat-LICENSE-ASL.txt tools/lib/apache-rat-NOTICE.txt >> >> >> >> Right, ever since then the jar-checksums task has not worked correctly. >> >> >> >> I dont know how you added a checksum, maybe with 'openssl sha1' >> >> yourself manually? >> >> >> >> But i needed to add a checksum for the commit to succeed, so i had to >> >> fix this task. >> >> >> >> On Thu, Jul 12, 2012 at 7:06 AM, Uwe Schindler <[email protected]> wrote: >> >> > What is different to Sunday afternoon? I added asm-all-debug.jar >> >> > with a >> >> checksum generated by my local windows tools and it worked? I don’t >> >> care about this ant task. >> >> > >> >> > ----- >> >> > Uwe Schindler >> >> > H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de >> >> > eMail: [email protected] >> >> > >> >> > >> >> >> -----Original Message----- >> >> >> From: Robert Muir [mailto:[email protected]] >> >> >> Sent: Thursday, July 12, 2012 1:03 PM >> >> >> To: [email protected] >> >> >> Subject: Re: svn commit: r1360619 - in /lucene/dev/trunk/lucene: >> >> >> build.xml common-build.xml tools/ivy.xml >> >> >> tools/lib/apache-rat-0.8.jar.sha1 >> >> >> tools/lib/apache-rat-LICENSE-ASL.txt tools/lib/apache-rat-NOTICE.txt >> >> >> >> >> >> ok but currently they are required, if you add a 3rd party jar and >> >> >> dont add a checksum for it, the build fails. >> >> >> >> >> >> so if we add back the dependency to resolve-tools for top-level >> >> >> lucene resolve (build.xml, only invoked a single time), then it all >> >> >> works. >> >> >> >> >> >> - <target name="resolve" depends="resolve-tools"> >> >> >> + <target name="resolve"> >> >> >> >> >> >> Otherwise, jar-checksums task will fail, because it will remove the >> >> >> asm jar's checksum. >> >> >> >> >> >> On Thu, Jul 12, 2012 at 6:59 AM, Uwe Schindler <[email protected]> >> wrote: >> >> >> > What does this f*cking task do? These checksums are a no-go for me. >> >> >> > I hate >> >> >> them and please remove them completely! It took me a hour on the >> >> >> weekend to get this shitty task working! >> >> >> > >> >> >> > ----- >> >> >> > Uwe Schindler >> >> >> > H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de >> >> >> > eMail: [email protected] >> >> >> > >> >> >> > >> >> >> >> -----Original Message----- >> >> >> >> From: Robert Muir [mailto:[email protected]] >> >> >> >> Sent: Thursday, July 12, 2012 12:55 PM >> >> >> >> To: [email protected] >> >> >> >> Subject: Re: svn commit: r1360619 - in /lucene/dev/trunk/lucene: >> >> >> >> build.xml common-build.xml tools/ivy.xml >> >> >> >> tools/lib/apache-rat-0.8.jar.sha1 >> >> >> >> tools/lib/apache-rat-LICENSE-ASL.txt tools/lib/apache-rat-NOTICE.txt >> >> >> >> >> >> >> >> again, please run 'ant jar-checksums' >> >> >> >> >> >> >> >> you will see the problem. >> >> >> >> >> >> >> >> On Thu, Jul 12, 2012 at 6:53 AM, Uwe Schindler <[email protected]> >> >> wrote: >> >> >> >> > Nat validate works form me. There is a checksum for asm so where >> is >> >> >> >> > the >> >> >> >> problem? >> >> >> >> > >> >> >> >> > ----- >> >> >> >> > Uwe Schindler >> >> >> >> > H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de >> >> >> >> > eMail: [email protected] >> >> >> >> > >> >> >> >> > >> >> >> >> >> -----Original Message----- >> >> >> >> >> From: Robert Muir [mailto:[email protected]] >> >> >> >> >> Sent: Thursday, July 12, 2012 12:49 PM >> >> >> >> >> To: [email protected] >> >> >> >> >> Subject: Re: svn commit: r1360619 - in /lucene/dev/trunk/lucene: >> >> >> >> >> build.xml common-build.xml tools/ivy.xml >> >> >> >> >> tools/lib/apache-rat-0.8.jar.sha1 >> >> >> >> >> tools/lib/apache-rat-LICENSE-ASL.txt tools/lib/apache-rat- >> NOTICE.txt >> >> >> >> >> >> >> >> >> >> Well, it was pretty related. >> >> >> >> >> >> >> >> >> >> I needed to add the checksums to commit this, or 'ant validate' >> would >> >> >> >> >> fail and jenkins would have been very angry! >> >> >> >> >> >> >> >> >> >> So i had to fix jar-checksums in order to commit! >> >> >> >> >> >> >> >> >> >> On Thu, Jul 12, 2012 at 6:47 AM, Uwe Schindler >> <[email protected]> >> >> >> wrote: >> >> >> >> >> > You committed this without documenting it anywhere. Sorry. If >> you >> >> >> >> >> > want this >> >> >> >> >> fixed, open issue and commit it separately. But not together with >> >> >> >> >> unrelated stuff. >> >> >> >> >> > >> >> >> >> >> > ----- >> >> >> >> >> > Uwe Schindler >> >> >> >> >> > H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de >> >> >> >> >> > eMail: [email protected] >> >> >> >> >> > >> >> >> >> >> > >> >> >> >> >> >> -----Original Message----- >> >> >> >> >> >> From: Robert Muir [mailto:[email protected]] >> >> >> >> >> >> Sent: Thursday, July 12, 2012 12:40 PM >> >> >> >> >> >> To: [email protected] >> >> >> >> >> >> Subject: Re: svn commit: r1360619 - in >> /lucene/dev/trunk/lucene: >> >> >> >> >> >> build.xml common-build.xml tools/ivy.xml >> >> >> >> >> >> tools/lib/apache-rat-0.8.jar.sha1 >> >> >> >> >> >> tools/lib/apache-rat-LICENSE-ASL.txt tools/lib/apache-rat- >> >> NOTICE.txt >> >> >> >> >> >> >> >> >> >> >> >> On Thu, Jul 12, 2012 at 6:34 AM, <[email protected]> >> wrote: >> >> >> >> >> >> > Author: uschindler >> >> >> >> >> >> > Date: Thu Jul 12 10:34:11 2012 >> >> >> >> >> >> > New Revision: 1360619 >> >> >> >> >> >> > >> >> >> >> >> >> > URL: http://svn.apache.org/viewvc?rev=1360619&view=rev >> >> >> >> >> >> > Log: >> >> >> >> >> >> > LUCENE-3950: Use ivy.cachepath for Apache RAT >> >> >> >> >> >> > >> >> >> >> >> >> > Removed: >> >> >> >> >> >> > >> >> >> >> >> >> > lucene/dev/trunk/lucene/tools/lib/apache-rat-0.8.jar.sha1 >> >> >> >> >> >> > lucene/dev/trunk/lucene/tools/lib/apache-rat-LICENSE- >> ASL.txt >> >> >> >> >> >> > lucene/dev/trunk/lucene/tools/lib/apache-rat-NOTICE.txt >> >> >> >> >> >> > Modified: >> >> >> >> >> >> > lucene/dev/trunk/lucene/build.xml >> >> >> >> >> >> > lucene/dev/trunk/lucene/common-build.xml >> >> >> >> >> >> > lucene/dev/trunk/lucene/tools/ivy.xml >> >> >> >> >> >> > >> >> >> >> >> >> > Modified: lucene/dev/trunk/lucene/build.xml >> >> >> >> >> >> > URL: >> >> >> >> >> >> > >> >> >> http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/build.xml?rev= >> >> >> >> >> >> > 136 0619&r1=1360618&r2=1360619&view=diff >> >> >> >> >> >> > >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> ================================================================ >> >> >> >> >> >> ====== >> >> >> >> >> >> > ======== >> >> >> >> >> >> > --- lucene/dev/trunk/lucene/build.xml (original) >> >> >> >> >> >> > +++ lucene/dev/trunk/lucene/build.xml Thu Jul 12 10:34:11 >> 2012 >> >> >> >> >> >> > @@ -227,7 +227,7 @@ >> >> >> >> >> >> > </forbidden-apis> >> >> >> >> >> >> > </target> >> >> >> >> >> >> > >> >> >> >> >> >> > - <target name="resolve" depends="resolve-tools"> >> >> >> >> >> >> > + <target name="resolve"> >> >> >> >> >> >> > <sequential> >> >> >> >> >> >> > <ant dir="test-framework" target="resolve" >> >> inheritall="false"> >> >> >> >> >> >> > <propertyset >> refid="uptodate.and.compiled.properties"/> >> >> >> >> >> >> > >> >> >> >> >> >> >> >> >> >> >> >> This part of the commit is a bug, it should go back to >> >> >> >> >> >> depending >> >> upon >> >> >> >> >> >> resolve- tools (or please remove the ASM.jar!!!!!!!) >> >> >> >> >> >> >> >> >> >> >> >> Its easy to see the bug, try 'ant jar-checksums' from >> >> >> >> >> >> top-level >> and >> >> >> >> >> >> watch what happens. >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> >> >> >> >> lucidimagination.com >> >> >> >> >> >> >> >> >> >> >> >> --------------------------------------------------------------------- >> >> >> >> >> >> To unsubscribe, e-mail: [email protected] For >> >> >> >> >> >> additional commands, e-mail: [email protected] >> >> >> >> >> > >> >> >> >> >> > >> >> >> >> >> > --------------------------------------------------------------------- >> >> >> >> >> > To unsubscribe, e-mail: [email protected] For >> >> >> >> >> > additional commands, e-mail: [email protected] >> >> >> >> >> > >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> >> >> >> lucidimagination.com >> >> >> >> >> >> >> >> >> >> --------------------------------------------------------------------- >> >> >> >> >> To unsubscribe, e-mail: [email protected] For >> >> >> additional >> >> >> >> >> commands, e-mail: [email protected] >> >> >> >> > >> >> >> >> > >> >> >> >> > --------------------------------------------------------------------- >> >> >> >> > To unsubscribe, e-mail: [email protected] >> >> >> >> > For additional commands, e-mail: [email protected] >> >> >> >> > >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> >> >> lucidimagination.com >> >> >> >> >> >> >> >> --------------------------------------------------------------------- >> >> >> >> To unsubscribe, e-mail: [email protected] >> >> >> >> For additional commands, e-mail: [email protected] >> >> >> > >> >> >> > >> >> >> > --------------------------------------------------------------------- >> >> >> > To unsubscribe, e-mail: [email protected] >> >> >> > For additional commands, e-mail: [email protected] >> >> >> > >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> >> lucidimagination.com >> >> >> >> >> >> --------------------------------------------------------------------- >> >> >> To unsubscribe, e-mail: [email protected] >> >> >> For additional commands, e-mail: [email protected] >> >> > >> >> > >> >> > --------------------------------------------------------------------- >> >> > To unsubscribe, e-mail: [email protected] >> >> > For additional commands, e-mail: [email protected] >> >> > >> >> >> >> >> >> >> >> -- >> >> lucidimagination.com >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: [email protected] >> >> For additional commands, e-mail: [email protected] >> > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> >> >> >> -- >> lucidimagination.com >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
-- lucidimagination.com --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
