[
https://issues.apache.org/jira/browse/LUCENE-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415199#comment-13415199
]
David Smiley commented on LUCENE-4167:
--------------------------------------
Keeping score... we're +1 for makeQuery() going away. Nice.
bq. My problem with this and with having the stored-field stuff as static
methods too, is that having them on Strategy it seems that they are the
only/preferred/recommended way to do something and I don't feel that's the case.
Okay then. So a SpatialUtil class with a private no-arg constructor with
static methods?
bq. then we should be fine with makeDistanceValueSource, right?
Yes, it is totally do-able with BBoxStrategy and should in theory be for any
Strategy. Until someone has the time to do it for BBoxStrategy (should be
easy) it could throw an UnsupportedOperationException.
By the way, I was not suggesting makeCustomValueSource() be on the Strategy
API, it would be specific to BBoxStrategy.
bq. We can have the DistanceCalculator or whatever is used to calculate the
distance, return the inverted distance.
So... are we then talking about a makeInvertedDistanceValueSource() method?
Hmm, this is somewhat less satisfying. Perhaps instead a boolean argument to
invert it?
bq. I like SpatialQueryCommand.
Good; lets do it.
> Remove the use of SpatialOperation
> ----------------------------------
>
> Key: LUCENE-4167
> URL: https://issues.apache.org/jira/browse/LUCENE-4167
> Project: Lucene - Java
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Chris Male
> Attachments: LUCENE-4167.patch,
> LUCENE-4167_migrate_com_spatial4j_core_query_to_Lucene_spatial.patch,
> LUCENE-4167_migrate_com_spatial4j_core_query_to_Lucene_spatial.patch
>
>
> Looking at the code in TwoDoublesStrategy I noticed
> SpatialOperations.BBoxWithin vs isWithin which confused me. Looking over the
> other Strategys I see that really only isWithin and Intersects is supported.
> Only TwoDoublesStrategy supports IsDisjointTo. The remainder of
> SpatialOperations are not supported.
> I don't think we should use SpatialOperation as this stage since it is not
> clear what Operations are supported by what Strategys, many Operations are
> not supported, and the code for handling the Operations is usually the same.
> We can spin off the code for TwoDoublesStrategy's IsDisjointTo support into a
> different Strategy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
