[
https://issues.apache.org/jira/browse/LUCENE-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415645#comment-13415645
]
Uwe Schindler commented on LUCENE-4228:
---------------------------------------
+1, great!The only problem I see is:
- If one wraps a Reader with a CharFilter that corrects offsets and on top of
that he wraps another custom FilterReader(not CharFilter), you loose offsets.
But thats not bad, if somebody does this he should know what he does *g*
> Refactor CharFilter to be a java.io.FilterReader
> ------------------------------------------------
>
> Key: LUCENE-4228
> URL: https://issues.apache.org/jira/browse/LUCENE-4228
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0-ALPHA
> Reporter: Robert Muir
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4228.patch
>
>
> Was looking at my old patch for LUCENE-2788, which isn't going to be easy,
> but besides that we can separately break out a nice refactoring to simplify
> the CharFilter logic.
> I think this would be a good idea for 4.0, since it gives us less API surface
> area.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
