[ 
https://issues.apache.org/jira/browse/LUCENE-4238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419463#comment-13419463
 ] 

Robert Muir commented on LUCENE-4238:
-------------------------------------

Thanks for the test Mark.

I think this is a horror in the test-framework actually, imagine say, that the 
bug is that 
NRTCachingDir's createOutput should be synced. Well we wrap in 
MockDirectoryWrapper for our tests,
which does all kinds of crazy shit, and its createOutput is synced. So tests 
wont find the bug.

On the other hand we dont want to NOT wrap in it because some of that crazy 
stuff we want to always do,
like checkindex on close.

So I will open an issue to clean this up. I think we should have a base class 
with the stuff that doesnt
need sync like checkIndex-on-close, and MDW extends that. Then in tests we can 
switch between the two
to catch bugs like this.
                
> NRTCachingDirectory has concurrency bug(s).
> -------------------------------------------
>
>                 Key: LUCENE-4238
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4238
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/store
>            Reporter: Mark Miller
>             Fix For: 4.0, 5.0
>
>         Attachments: LUCENE-4238.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to