[ 
https://issues.apache.org/jira/browse/LUCENE-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421170#comment-13421170
 ] 

David Smiley commented on LUCENE-4251:
--------------------------------------

For reference:

https://svn.apache.org/repos/asf/lucene/dev/trunk/lucene/spatial/src/java/org/apache/lucene/spatial/util/ValueSourceFilter.java

https://svn.apache.org/repos/asf/lucene/dev/trunk/solr/core/src/java/org/apache/solr/search/function/ValueSourceRangeFilter.java

The Lucene spatial util one wraps a Filter whereas Solr's wraps a ValueSource.  
Furthermore, even after this refactoring, it's not likely Solr's will go away 
because it extends SolrFilter.  I like that Solr's has configurable inclusive & 
exclusivity.

My initial goal was to move out the one in spatial because it seemed like 
something useful in the query module, and then I found the Solr one which 
seemed the same but not quite.
                
> Port Solr's ValueSourceRangeFilter to Lucene query module
> ---------------------------------------------------------
>
>                 Key: LUCENE-4251
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4251
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/other
>            Reporter: David Smiley
>            Priority: Minor
>             Fix For: 4.0
>
>
> Lucene spatial has ValueSourceFilter and Solr has ValueSourceRangeFilter 
> (that has some more features).  And someone asked for this in LUCENE-3875 
> too.  It should be ported over to the Lucene query module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to