[
https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422027#comment-13422027
]
Robert Muir commented on LUCENE-4044:
-------------------------------------
{quote}
The only thing I want to add is an ANT task (e.g., using ASM like the other
one), that creates the META-INF/services files automatically. We can then do
the same in core for codecs or postings. It just collects all .class files from
a FileSet that extends a specfic class and adds them to a services file. But
that has time, currently all factories must be added manually, but this can go
in!
{quote}
I agree this would be nice, for safety in the meantime I added
TestAllAnalyzersHaveFactories, which checks that both we have a factory for
every Tokenizer/TokenFilter/CharFilter and that the SPI is configured correctly
(since it uses forName to validate this) and fails if we don't.
Its not a perfect solution but just to prevent stupid mistakes.
> Add NamedSPILoader support to TokenizerFactory, TokenFilterFactory and
> CharFilterFactory
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-4044
> URL: https://issues.apache.org/jira/browse/LUCENE-4044
> Project: Lucene - Core
> Issue Type: Sub-task
> Components: modules/analysis
> Reporter: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-4044.patch
>
>
> In LUCENE-2510 I want to move all the analysis factories out of Solr and into
> the directories with what they create. This is going to hamper Solr's
> existing strategy for supporting {{solr.*}} package names, where it replaces
> {{solr}} with various pre-defined package names. One way to tackle this is
> to use NamedSPILoader so we simply look up {{StandardTokenizerFactory}} for
> example, and find it wherever it is, as long as it is defined as a service.
> This is similar to how we support Codecs currently.
> As noted by Robert in LUCENE-2510, this would also have the benefit of
> meaning configurations could be less verbose, would aid in fully decoupling
> the analysis module from Solr, and make the analysis factories easier to
> interact with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
