[
https://issues.apache.org/jira/browse/LUCENE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422464#comment-13422464
]
Uwe Schindler edited comment on LUCENE-2510 at 7/25/12 6:09 PM:
----------------------------------------------------------------
Fixed with merge of sub-task.
We should open new issues for:
- Fix the Factory API to be more useable for Lucene programmers from Hibernate,
ES, and other projects needing configureable analyzers
- Clean up solr/contrib/analysis-extras (this contrib contains no factory code
anymore just some JARS + The ICUCollationKeyField). We can nuke the whole
contrib now, users can simply extract the analysis/morfologic,icu,smarcn,...
JARS and put into their Solr plugins folder. I would move the
ICUCollationFieldType to core and add icu.jar there. Its already needed by
other contribs, so deduplicating it by adding to core makes much sense
- We should maybe add a script to Solr that downloads the JAR files of the
former extra analysis from Maven/Ivy and install in plugin folder. No need to
ship this seldom used stuff with the main WAR.
- Automatism to create META-INF/services (also affects Codecs&PostingsFormat).
2 possibilities (using APT and do it in JavaC using custom annotation while
compiling, ASM-based ANT task like forbidden APIS to find all
subclasses/implementations of an interface after compiling).
was (Author: thetaphi):
Fixed with merge of sub-task.
We should open new issues for:
- Fix the Factory API to be more useable for Lucene programmers from Hibernate,
ES, and othe projects needing configureable analyzers
- Clean up solr/contrib/analysis-extras (this contrib contains no factory code
anymore just some JARS + The ICICollationKeyField). We can nuke the whole
contrib now, users can simply extract the analysis/morfologic,icu,smarcn,...
JARS and put into their Solr plugins folder. I would move the
ICUCollationFieldType to core and add icu.jar there. Its already needed by
other contribs, so deduplicating it by adding to core makes much sense
- We should maybe add a script to sol that downloads the JAR files of the
former extra analysis from Maven/Ivy and install in plugin folder. No need to
ship this seldom used stuff with the main WAR.
- Automatism to create META-INF/services (also affects Codecs&PostingsFormat).
2 possibilities (using APT and do it in JavaC using custom annotation,
ASM-based ANT task like forbidden APIS to find all subclasses/implementations
of an interface).
> migrate solr analysis factories to analyzers module
> ---------------------------------------------------
>
> Key: LUCENE-2510
> URL: https://issues.apache.org/jira/browse/LUCENE-2510
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/analysis
> Affects Versions: 4.0-ALPHA
> Reporter: Robert Muir
> Assignee: Uwe Schindler
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-2510-movefactories.sh,
> LUCENE-2510-movefactories.sh, LUCENE-2510-multitermcomponent.patch,
> LUCENE-2510-multitermcomponent.patch, LUCENE-2510-parent-classes.patch,
> LUCENE-2510-parent-classes.patch, LUCENE-2510-parent-classes.patch,
> LUCENE-2510-resourceloader-bw.patch, LUCENE-2510-simplify-tests.patch,
> LUCENE-2510.patch, LUCENE-2510.patch, LUCENE-2510.patch
>
>
> In LUCENE-2413 all TokenStreams were consolidated into the analyzers module.
> This is a good step, but I think the next step is to put the Solr factories
> into the analyzers module, too.
> This would make analyzers artifacts plugins to both lucene and solr, with
> benefits such as:
> * users could use the old analyzers module with solr, too. This is a good
> step to use real library versions instead of Version for backwards compat.
> * analyzers modules such as smartcn and icu, that aren't currently available
> to solr users due to large file sizes or dependencies, would be simple
> optional plugins to solr and easily available to users that want them.
> Rough sketch in this thread:
> http://www.lucidimagination.com/search/document/3465a0e55ba94d58/solr_and_analyzers_module
> Practically, I havent looked much and don't really have a plan for how this
> will work yet, so ideas are very welcome.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
