[
https://issues.apache.org/jira/browse/LUCENE-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-4273:
---------------------------------------
Attachment: LUCENE-4273.patch
Patch looks great!
I tweaked javadocs and fixed one NPE in DirectPostingsFormat ... I think it's
ready.
> Fix DocsEnum freq flag consistent with DocsAndPositionsEnum flags
> -----------------------------------------------------------------
>
> Key: LUCENE-4273
> URL: https://issues.apache.org/jira/browse/LUCENE-4273
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-4273.patch, LUCENE-4273.patch
>
>
> Followup from LUCENE-4230
> Currently today to pull freq() from a docsEnum, you have to pass a boolean
> 'needsFreqs=true'. If the field omitsTF, then it returns null (and you need
> to call it again, with 'needsFreqs=false', in which case you are not supposed
> to call freq().
> We fixed this in D&PEnum in 4230: as you can tell from the fieldinfos whether
> they are there or not, there is no need to return null, it makes consumer
> code complicated.
> So this issue is just to have docs(Bits, reuse) which calls docs(Bits, reuse,
> FLAG_FREQS) by default. if they arent there, the docsenum returns 1 for
> freq().
> So calling docs(Bits, reuse, 0) is just an optimization hint to the codec
> that you never need them (same as the payload/offset flags for
> docsAndPositions)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
