[ 
https://issues.apache.org/jira/browse/LUCENE-3985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427168#comment-13427168
 ] 

Uwe Schindler commented on LUCENE-3985:
---------------------------------------

bq. You can add the signatures to the forbidden API list under jdk.txt (with 
comment) or a new file (but don't forget to place this new signature file in 
Lucene and Solr's filesets).

I think, to not complicate the filesets, we should use for this case simply 
jdk.txt and not a separate file (as all signatures refer to JDK. Otherwise we 
must rename jdk.txt to defaultCharsJdk.txt or whatever). Just place a comment 
in the introduction and add the signatures to jdk.txt. The other txt files in 
banned methods are more for other parts of lucene code-base (like test-only), 
or like commons-io, refer to a solr-only lib.
                
> Refactor support for thread leaks
> ---------------------------------
>
>                 Key: LUCENE-3985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-3985.patch, LUCENE-3985.patch, LUCENE-3985.patch, 
> LUCENE-3985.patch
>
>
> This will be duplicated in the runner and in LuceneTestCase; try to 
> consolidate.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to