[ 
https://issues.apache.org/jira/browse/LUCENE-4290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429049#comment-13429049
 ] 

Michael McCandless commented on LUCENE-4290:
--------------------------------------------

Wow :)  This looks very nice!

Should we move EMPTY into DocsAndPositionsEnum?

This isn't just a cutover from term vectors to postings right?  It actually 
scores each passage as if it were its own hit/document matching a search?  Ie 
the passage ranking/selection differs from the two existing highlighters.

I like the EMPTY_INDEXREADER (so MTQs do no rewrite work).
                
> basic highlighter that uses postings offsets
> --------------------------------------------
>
>                 Key: LUCENE-4290
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4290
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: modules/other
>            Reporter: Robert Muir
>         Attachments: LUCENE-4290.patch
>
>
> We added IndexOptions.DOCS_AND_FREQS_AND_POSITIONS_AND_OFFSETS so you can 
> efficiently compress character offsets in the postings list, but nothing yet 
> makes use of this.
> Here is a simple highlighter that uses them: it doesn't have many tests or 
> fancy features, but I think its ok for the sandbox/ (maybe with a couple more 
> tests)
> Additionally I didnt do any benchmarking.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to