[ 
https://issues.apache.org/jira/browse/LUCENE-4291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-4291:
--------------------------------

    Attachment: LUCENE-4291.patch

Here's a patch: with regenerations.

Note that, by default 'ant jflex' gave me an error for all the includes (as of 
jflex r612).

So thats why you see changes like:
{noformat}
-%include 
src/java/org/apache/lucene/analysis/charfilter/HTMLCharacterEntities.jflex
+%include HTMLCharacterEntities.jflex
{noformat}

It seems jflex now expects these file paths to be relative to the input file?
                
> consider reducing jflex buffer sizes
> ------------------------------------
>
>                 Key: LUCENE-4291
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4291
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: modules/analysis
>            Reporter: Robert Muir
>         Attachments: LUCENE-4291.patch
>
>
> Spinoff from SOLR-3684.
> Most lucene tokenizers have some buffer size, e.g. in 
> CharTokenizer/ICUTokenizer its char[4096].
> But the jflex tokenizers use char[16384] by default, which seems overkill. 
> I'm not sure we really see any performance bonus by having such a huge buffer 
> size as a default.
> There is a jflex parameter to set this: I think we should consider reducing 
> it.
> In a configuration like solr, tokenizers are reused per-thread-per-field,
> so these can easily stack up in RAM.
> Additionally CharFilters are not reused so the configuration in e.g.
> HtmlStripCharFilter might not be great since its per-document garbage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to