[
https://issues.apache.org/jira/browse/SOLR-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432724#comment-13432724
]
Robert Muir commented on SOLR-3725:
-----------------------------------
Thanks Michael! I ran package-src-tgz versus package-local-src-tgz a few times
and compared the file list in the tar output,
actually it should be 30M but includes some unnecessary .jars. I iterated until
these were equal, and came up with this simpler
pattern for the .jars
{noformat}
- excludes="build ${package.dir}/** ${dist}/**
- example/webapps/*.war example/exampledocs/post.jar
+ excludes="build/** ${package.dir.rel}/** ${dist.rel}/**
+ example/webapps/*.war example/lib/**
+ **/*.jar
{noformat}
I'll commit your patch soon (with this tweak).
> package-local-src-tgz target is pulling in non-source jars, dist/** and
> package/**
> ----------------------------------------------------------------------------------
>
> Key: SOLR-3725
> URL: https://issues.apache.org/jira/browse/SOLR-3725
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Affects Versions: 4.0-ALPHA
> Reporter: Michael Dodsworth
> Priority: Minor
> Fix For: 4.1
>
> Attachments: SOLR-3725.patch
>
>
> package-local-src-tgz generates a 141M archive which contains a bunch of
> non-source jars:
> {code}
> tar tfz apache-solr-4.0-SNAPSHOT-src.tgz | grep -E '(war|jar)$' | wc -l
> 134
> {code}
> It looks like we're expecting dist/** and package/** to be excluded:
> {code:xml}
> <tarfileset dir="." prefix="${fullnamever}/solr"
> excludes="build ${package.dir}/** ${dist}/**
> example/webapps/*.war
> example/exampledocs/post.jar
> lib/README.committers.txt **/data/ **/logs/*
> **/*.sh **/bin/ scripts/
> .idea/ **/*.iml **/pom.xml" />
> {code}
> The issue is that package.dir and dist refer to absolute paths; excludes
> assumes relative paths.
> It's also pulling in all the contrib/**/lib/ and example/lib/ jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
