[
https://issues.apache.org/jira/browse/LUCENE-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433548#comment-13433548
]
Uwe Schindler commented on LUCENE-4303:
---------------------------------------
Patch looks fine, I dont like the newInstance().getClass(), but as quick fix
this is fine. In my opinion, the getEncoder() should request the encoder from
ReosurceLoader. But its also fine how it is implemented at the moment.
Some minor things: the inject field should have no access modifier, as test is
in same package, so package-private is fine. Protected means access from
subclasses, which is not the case.
The tests are also fine, ClassPathResourceLoader is fine here!
> Analysis factories should use ResourceLoader, not Class.forName
> ---------------------------------------------------------------
>
> Key: LUCENE-4303
> URL: https://issues.apache.org/jira/browse/LUCENE-4303
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/analysis
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Attachments: LUCENE-4303_Use_ResourceLoader_not_class_forName.patch
>
>
> This affects SnowballPorterFilterFactory and PhoneticFilterFactory.
> In Solr I encountered this problem when I specified an encoder and I was
> forced to put the library in WEB-INF/lib instead of /solr/lib/.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
