[
https://issues.apache.org/jira/browse/SOLR-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435168#comment-13435168
]
Steven Rowe edited comment on SOLR-2747 at 8/16/12 2:06 AM:
------------------------------------------------------------
bq. FYI I tried to run the patch on lucene's changes but got
Hmm, I don't get any errors like that. My perl:
This is perl, v5.10.1 (*) built for i686-cygwin-thread-multi-64int
(with 13 registered patches, see perl -V for more detail)
I got the same damned success on Debian Squeeze v6.0.5, where the perl version
is (unfortunately) the same:
This is perl, v5.10.1 (*) built for x86_64-linux-gnu-thread-multi
(with 56 registered patches, see perl -V for more detail)
I see that the error you're getting is on line 742:
{code}
739: my $project_info_json = get_url_contents("$project_info_url/$product");
740:
741: my $project_info = json2perl($project_info_json);
742: for my $version (@{$project_info->{versions}}) {
{code}
The json2perl subroutine converts the JSON response from JIRA into a
Perl-compatible serialized nested data structure, then {{eval}}'s the result to
reconstitute. Apparently the {{eval}} is failing for you - when {{eval}}
fails, it returns the undefined value, which would cause the error you're
getting when trying to treat an undefined value as a hash reference. Maybe
JIRA isn't sending back the right thing?
This version of the patch adds a script failure when {{eval}} fails, and prints
out the {{eval}} error message, along with the munged JSON->Perl string that
triggered the error - would you please try it, Robert?
was (Author: steve_rowe):
.bq FYI I tried to run the patch on lucene's changes but got: {{\[exec] Not
a HASH reference at}} [...]
Hmm, I don't get any errors like that. My perl:
This is perl, v5.10.1 (*) built for i686-cygwin-thread-multi-64int
(with 13 registered patches, see perl -V for more detail)
I got the same damned success on Debian Squeeze v6.0.5, where the perl version
is (unfortunately) the same:
This is perl, v5.10.1 (*) built for x86_64-linux-gnu-thread-multi
(with 56 registered patches, see perl -V for more detail)
I see that the error you're getting is on line 742:
{code}
739: my $project_info_json = get_url_contents("$project_info_url/$product");
740:
741: my $project_info = json2perl($project_info_json);
742: for my $version (@{$project_info->{versions}}) {
{code}
The json2perl subroutine converts the JSON response from JIRA into a
Perl-compatible serialized nested data structure, then {{eval}}'s the result to
reconstitute. Apparently the {{eval}} is failing for you - when {{eval}}
fails, it returns the undefined value, which would cause the error you're
getting when trying to treat an undefined value as a hash reference. Maybe
JIRA isn't sending back the right thing?
This version of the patch adds a script failure when {{eval}} fails, and prints
out the {{eval}} error message, along with the munged JSON->Perl string that
triggered the error - would you please try it, Robert?
> Include formatted Changes.html for release
> ------------------------------------------
>
> Key: SOLR-2747
> URL: https://issues.apache.org/jira/browse/SOLR-2747
> Project: Solr
> Issue Type: Improvement
> Reporter: Martijn van Groningen
> Assignee: Steven Rowe
> Priority: Minor
> Fix For: 4.1
>
> Attachments: SOLR-2747.patch, SOLR-2747.patch, SOLR-2747.patch
>
>
> Just like when releasing Lucene, Solr should also have a html formatted
> changes file.
> The Lucene Perl script (lucene/src/site/changes/changes2html.pl) should be
> reused.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
