[
https://issues.apache.org/jira/browse/LUCENE-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-3849:
--------------------------------
Attachment: LUCENE-3849.patch
here is an updated patch, fixing all the analyzers and also removing the -1.
Additionally i fixed basetokenstreamtestcase to apply the checkClearAttributes
etc before end() too, and fixed things like StandardTokenizer that sometimes
act like stopfilters (remove too-long tokens) to apply these in end(), in case
they happen to appear at the end of a multivalued field.
There are unrelated problems in facets/ it has lots of tokenstreams that never
call clearAttributes. I will open an issue to clean that up, its not possible
to proceed until those tokenstreams are fixed.
> position increments should be implemented by TokenStream.end()
> --------------------------------------------------------------
>
> Key: LUCENE-3849
> URL: https://issues.apache.org/jira/browse/LUCENE-3849
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 3.6, 4.0-ALPHA
> Reporter: Robert Muir
> Attachments: LUCENE-3849.patch, LUCENE-3849.patch
>
>
> if you have pages of a book as multivalued fields, with the default position
> increment gap
> of analyzer.java (0), phrase queries won't work across pages if one ends with
> stopword(s).
> This is because the 'trailing holes' are not taken into account in end(). So
> I think in
> TokenStream.end(), subclasses of FilteringTokenFilter (e.g. stopfilter)
> should do:
> {code}
> super.end();
> posIncAtt += skippedPositions;
> {code}
> One problem is that these filters need to 'add' to the posinc, but currently
> nothing clears
> the attributes for end() [they are dirty, except offset which is set by the
> tokenizer].
> Also the indexer should be changed to pull posIncAtt from end().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
