[ 
https://issues.apache.org/jira/browse/LUCENE-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438630#comment-13438630
 ] 

Uwe Schindler commented on LUCENE-4317:
---------------------------------------

To come back to Robert: We can of course remove the whole FieldTypes stuff 
altogether and only do this in Analyzer (which is then somehow a schema 
replacement). But then Analyzer.tokenStream() should be able to take other data 
types than Reader. If this would be the case I would +1 all your suggestions, 
izt would also solve the stupid wrapping of Strings with StringReader (that 
would be needed with removal of StringField) :-)

Btw.: As Solr is working on Strings solely, Solr can include the numerics into 
analyzers (and they do), but this adds "locale specific" String to numeric 
translation to the Tokenizer (which solr adds). I dont want this as the data 
sources for numeric fields are in most cases *no strings*.
                
> Field.java does not reuse its inlined Keyword-TokenStream
> ---------------------------------------------------------
>
>                 Key: LUCENE-4317
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4317
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>    Affects Versions: 4.0-BETA
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 5.0, 4.0
>
>         Attachments: LUCENE-4317.patch
>
>
> Field.java contains a inlined Keyword-TokenStream. Unfortunately this one is 
> recreated all the time, although one reuses the same Field instance. For 
> NumericTokenStream Field.java reuses it, but the Keyword one not.
> We should apply the same logic and lazy init the TokenStream with a setter 
> for the String value and reset(). This would be looking identical to 
> SetNumeric(xx).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to