Robert Muir created LUCENE-4321:
-----------------------------------

             Summary: java.io.FilterReader considered harmful
                 Key: LUCENE-4321
                 URL: https://issues.apache.org/jira/browse/LUCENE-4321
             Project: Lucene - Core
          Issue Type: Bug
    Affects Versions: 4.0-BETA
            Reporter: Robert Muir
             Fix For: 5.0, 4.0
         Attachments: LUCENE-4321.patch

See Dawid's email: http://find.searchhub.org/document/64b0a28c53faf39

Reader.java is fine, it has lots of methods like read(), read(char[]), 
read(CharBuffer), skip(), but these all have default implementations delegating 
to read(char[], int, int).

Unfortunately FilterReader delegates too many unnecessary things such as read() 
and skip() in a broken way. It should have just left these alone.

This can cause traps for someone upgrading because they have to override 
multiple methods, when read(char[], int, int) should be enough, and all Reader 
methods will then work correctly.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to