another random side note: whereever we 'output' this changes in the solr source distribution, I think we should somehow also run changes2html on the lucene CHANGES.txt too?
This way solr users looking at the solr src dist can easily see 'all the changes' ? On Wed, Aug 29, 2012 at 12:25 PM, Robert Muir <[email protected]> wrote: > Sorry, correct patch: the script is in lucene/site/changes. the target > dir ... this seems to make sense? or should we put it somewhere else? > > prepare-release succeeds with this: > > Index: solr/build.xml > =================================================================== > --- solr/build.xml (revision 1378630) > +++ solr/build.xml (working copy) > @@ -320,8 +320,8 @@ > <!-- Exclude clover license files incompatible with the ASL --> > <delete dir="${svn.export.dir}/lucene/tools/clover"/> > > - <build-changes changes.src.dir="${svn.export.dir}/site/changes" > - changes.target.dir="${svn.export.dir}/docs/changes"/> > + <build-changes changes.src.dir="${svn.export.dir}/lucene/site/changes" > + changes.target.dir="${svn.export.dir}/solr/docs/changes"/> > > <tar destfile="${source.package.file}" compression="gzip" longfile="gnu"> > <tarfileset dir="${svn.export.dir}" > > > On Wed, Aug 29, 2012 at 12:22 PM, Robert Muir <[email protected]> wrote: >> On Wed, Aug 29, 2012 at 12:10 PM, Steven Rowe (JIRA) <[email protected]> wrote: >>> >>> [ >>> https://issues.apache.org/jira/browse/SOLR-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >>> ] >>> >>> Steven Rowe reopened SOLR-2747: >>> ------------------------------- >>> >>> >>> Solr-Artifacts-trunk failed because {{changes2html.pl}} couldn't be found: >>> from [https://builds.apache.org/job/Solr-Artifacts-trunk/1958/]: >>> >> >> >> This looks like a copy-paste bug in my packaging handling for the >> svn-export case (I copied from lucene). >> >> JIRA is too slow for me now, but I think the fix should be something like >> this? >> >> Index: solr/build.xml >> =================================================================== >> --- solr/build.xml (revision 1378630) >> +++ solr/build.xml (working copy) >> @@ -320,8 +320,8 @@ >> <!-- Exclude clover license files incompatible with the ASL --> >> <delete dir="${svn.export.dir}/lucene/tools/clover"/> >> >> - <build-changes changes.src.dir="${svn.export.dir}/site/changes" >> - changes.target.dir="${svn.export.dir}/docs/changes"/> >> + <build-changes changes.src.dir="${svn.export.dir}/solr/site/changes" >> + >> changes.target.dir="${svn.export.dir}/solr/docs/changes"/> >> >> <tar destfile="${source.package.file}" compression="gzip" >> longfile="gnu"> >> <tarfileset dir="${svn.export.dir}" >> >> >> -- >> lucidworks.com > > > > -- > lucidworks.com -- lucidworks.com --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
