Hoss Man created SOLR-3768:
------------------------------

             Summary: add some prelim assertions to OverseerTest
                 Key: SOLR-3768
                 URL: https://issues.apache.org/jira/browse/SOLR-3768
             Project: Solr
          Issue Type: Test
            Reporter: Hoss Man


There isn't much i understand about OverseerTest, but today while doing a full 
test run I got an unreproducible assertion failure from this line...

{noformat}
assertNotNull("could not find counter for shard:" + ids[i], ai);
{noformat}

...in which the assertion message indicated that not only was "ai" null, but 
"ids[i]" was null as well.

Poking arround the test a bit, i think what's happening here is that some of 
the preliminary logic in testShardAssignmentBigger has bounded wait loops to 
"make sure ...." things have happened, but there is no assertion that these 
things actually happen if that the loop bound is exhausted - which can lead to 
missleading/confusing errors further on in the test.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to