[ 
https://issues.apache.org/jira/browse/SOLR-3699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445047#comment-13445047
 ] 

Mark Miller commented on SOLR-3699:
-----------------------------------

bq. it's private,

Ah, okay, did not catch that.

bq. something needs to close the DirectoryFactory that 
SolrCore.initDirectoryFactory() already created.

Yeah, brain murmur - for some reason I was thinking DirectoryFactory was used 
globally across cores.

This is probably fine then. Once I commit some stuff from my workspace, I'll 
actually apply the patch and try and consider this some more.
                
> SolrIndexWriter constructor leaks Directory if Exception creating 
> IndexWriterConfig
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-3699
>                 URL: https://issues.apache.org/jira/browse/SOLR-3699
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Mark Miller
>             Fix For: 4.0
>
>         Attachments: SOLR-3699.patch, SOLR-3699.patch, SOLR-3699.patch, 
> SOLR-3699.patch
>
>
> in LUCENE-4278 i had to add a hack to force SimpleFSDir for 
> CoreContainerCoreInitFailuresTest, because it doesnt close its Directory on 
> certain errors.
> This might indicate a problem that leaks happen if certain errors happen 
> (e.g. not handled in finally)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to