[ 
https://issues.apache.org/jira/browse/LUCENE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448418#comment-13448418
 ] 

Robert Muir commented on LUCENE-4354:
-------------------------------------

{quote}
not even generate-maven-artifacts passes without more permgen (Windows 7 64).
{quote}

Thats because you were a bit over-eager here:
{noformat}
-  <target name="generate-maven-artifacts"
-          depends="install-maven-tasks, filter-pom-templates, package, 
javadocs">
+  <target name="generate-maven-artifacts">
{noformat}

instead, depend on install-maven-tasks here (it seems redundant, its not).
its then loaded once, and the property is passed in the 
uptodate.and.compiled.properties and 
you will see in the log that its task is only installed once rather than 
over-and-over :)

I fixed this a while ago and i fixed it locally in your patch (along with 
similar stuff) and it clears this up fine.
I'll take care of it (with a note not to remove the depends), I just wanted to 
explain!

                
> add validate-maven task to check maven dependencies
> ---------------------------------------------------
>
>                 Key: LUCENE-4354
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4354
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4354-dep-fix.patch, 
> LUCENE-4354_hacked_lucene_only.patch, LUCENE-4354.patch, LUCENE-4354.patch, 
> LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, LUCENE-4354.patch, 
> LUCENE-4354.patch, LUCENE-4354.patch
>
>
> We had a situation where the maven artifacts depended on the wrong version of 
> tika: we should test that the maven dependencies are correct.
> An easy way to do this is to force it to download all of its dependencies, 
> and then run our existing license checks over that.
> This currently fails: maven is bringing in some extra 3rd party libraries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to