[ 
https://issues.apache.org/jira/browse/LUCENE-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449593#comment-13449593
 ] 

Robert Muir commented on LUCENE-4364:
-------------------------------------

its completely untested except with offset=0 and length=length, thats my 
problem (that doesnt count).

its also totally unnecessary to support: there is absolutely, positively, zero 
use-case.
ill change the patch to add it back. ill also remove the assert 
getFilePointer() == 0L (nothing depends on that).

                
> MMapDirectory makes too many maps for CFS
> -----------------------------------------
>
>                 Key: LUCENE-4364
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4364
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-4364.patch, LUCENE-4364.patch, LUCENE-4364.patch, 
> LUCENE-4364.patch, LUCENE-4364.patch
>
>
> While looking at LUCENE-4123, i thought about this:
> I don't like how mmap creates a separate mapping for each CFS slice, to me 
> this is way too many mmapings.
> Instead I think its slicer should map the .CFS file, and then when asked for 
> an offset+length slice of that, it should be using .duplicate()d buffers of 
> that single master mapping.
> then when you close the .CFS it closes that one mapping.
> this is probably too scary for 4.0, we should take our time, but I think we 
> should do it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to