On Sat, Sep 8, 2012 at 8:37 AM, Uwe Schindler <[email protected]> wrote: > The missing ones on clones are just standard Lucene behaviour. Clones are > never closed in Lucene. But we have correct support for it now (this is > important for CFS, as all CFS child files are just clones, so they should > throw AlreadyClosed after closing them), this was also missing in previous > MMapDir. I added 2 new tests that check for clones we independent from > master, so when they are closed, other clones are unaffected. Just the close > of the master/slicer now forcefully closes all childs.
exactly: clones are SOMETIMES now closed :) In any case they are closable so it should be fine. I was just being pedantic because this test tests MMapDir directly (no MockDirWrapper). Thats why only windows caught the missing close() here. But I think its best this test use MMapDir directly. Thanks for the new tests! -- lucidworks.com --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
