[
https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated LUCENE-4362:
-----------------------------------
Attachment: LUCENE-4326_trunk.patch
LUCENE-4362_4x.patch
Current versions, but I can't build the jflex files, and I'm still having the
test problem with the unresponsive process.
So, anyone who already has jflex set up want to try applying this, running
jflex and maybe the tests?
The state of these patches:
> all the tabs removed from java files that don't have corresponding .jj or
> .jflex files.
> All the tabs removed from the .jflex and jj files. I'm a little nervous about
> this...
> Partial run of jflex until I ran out of memory, which I can't seem to get
> around. So a couple the corresponding generated files have been changed
> (several StandardTokenizerImpl's and a ClassicTokenizerImpl).
> I'm sure as Robert points out that there'll be a couple of tabs re-introduced
> by running the parser compilers, but at least the source going in doesn't
> have any.
> My daughter and her husband want to go hiking. I've got better things to do
> for a while than fight jflex this afternoon <G>...
Or should I just forget about the jflex nonsense for the time being?
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch,
> LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author
> tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author
> tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
