[
https://issues.apache.org/jira/browse/LUCENE-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452087#comment-13452087
]
Shai Erera commented on LUCENE-4372:
------------------------------------
bq. Do we? I think i'm just proposing to modify the existing 'if' check (if
curDocs == null) to do nothing at all or to throw an exception earlier
I don't think so. That 'if' only indicates whether the RAM limit has been
reached, and we don't cache anymore. But the collector doesn't know if the
wrapped Collector needs to receive the documents that are still to be collected
or not.
CachingCollector is an optimization. If you can spare 10 MB of cache, and you
happen to execute queries that answer #documents that can be cached within that
limit, then as in the case Yonik describes, you can execute the query once,
collect the docs (by a real Collector) and cache them (CachingCollector) in
order to replay to another Collector. If there wasn't enough RAM, you cannot
use replay() (you'll hit IllegalStateEx).
The 'if' I was talking about adding is inside "if (cacheDocs == null)" to
follow by an "if (collector == null)" and pass a null Collector from the
create() that is not interested in wrapping a Collector.
> CachingCollector.create(boolean, boolean, double) is trappy
> -----------------------------------------------------------
>
> Key: LUCENE-4372
> URL: https://issues.apache.org/jira/browse/LUCENE-4372
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
>
> Followup to LUCENE-3102.
> Shai proposed a method that just caches all scores so they can be replayed:
> {quote}
> Do you think we can modify this Collector to not necessarily wrap another
> Collector? We have such Collector which stores (in-memory) all matching doc
> IDs + scores (if required). Those are later fed into several processes that
> operate on them (e.g. fetch more info from the index etc.). I am thinking, we
> can make CachingCollector optionally wrap another Collector and then someone
> can reuse it by setting RAM limit to unlimited (we should have a constant for
> that) in order to simply collect all matching docs + scores.
> {quote}
> But Mike had concerns about the RAM usage:
> {quote}
> I'd actually rather not have the constant – ie, I don't want to make
> it easy to be unlimited? It seems too dangerous... I'd rather your
> code has to spell out 10*1024 so you realize you're saying 10 GB (for
> example).
> {quote}
> My concern here is what happens when you dont specify enough, I think those
> hits are just silently dropped (which is worse than using lots of RAM).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
