[
https://issues.apache.org/jira/browse/LUCENE-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453180#comment-13453180
]
Uwe Schindler commented on LUCENE-2163:
---------------------------------------
If doClose is protected by close() it is a no-op, so it does not matter if
there is a sync or not :-)
The other ones I already wanted to remove while refactoring, I just missed to
do it. I think this issue is a relict from earlier times... I would just commit
that removal. If you sync on reopen, you must sync everything.
> Remove synchronized from DirReader.reopen/clone
> -----------------------------------------------
>
> Key: LUCENE-2163
> URL: https://issues.apache.org/jira/browse/LUCENE-2163
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Reporter: Michael McCandless
> Priority: Minor
> Fix For: 4.1
>
> Attachments: LUCENE-2163.patch
>
>
> Spinoff from LUCENE-2161, where the fact that DirReader.reopen is
> sync'd was dangerous in the context of NRT (could block all searches
> against that reader when CMS was throttling). So, with LUCENE-2161,
> we're removing the synchronization when it's an NRT reader that you're
> reopening.
> But... why should we sync even for a "normal" reopen? There are
> various sync'd methods on IndexReader/DirReader (we are reducing that,
> with LUCENE-2161 and also LUCENE-2156), but, in general it doesn't
> seem like "normal" reopen really needs to be sync'd. Performing a reopen
> shouldn't incur any chance of blocking a search...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
