[ 
https://issues.apache.org/jira/browse/LUCENE-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated LUCENE-4173:
---------------------------------

    Attachment: 
LUCENE-4173_remove_IgnoreIncompatibleGeometry,_fail_when_given_the_exact_shape_needed.patch

Updated the patch:
* renamed the test method with the underscore to be 
"convertShapeFromGetDocuments" instead
* In BBoxStrategy.makeValueSource, I moved my "TODO" bbox shape similarity idea 
to a comment on a JIRA issue.  And I modified this makeValueSource to fail if a 
rectangle is not given, instead of coalescing via getBoundingBox().
                
> Remove IgnoreIncompatibleGeometry for SpatialStrategys
> ------------------------------------------------------
>
>                 Key: LUCENE-4173
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4173
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial
>            Reporter: Chris Male
>            Assignee: David Smiley
>             Fix For: 4.0
>
>         Attachments: LUCENE-4173.patch, 
> LUCENE-4173_remove_ignoreIncompatibleGeometry,_fail_when_given_the_exact_shape_needed.patch,
>  
> LUCENE-4173_remove_IgnoreIncompatibleGeometry,_fail_when_given_the_exact_shape_needed.patch
>
>
> Silently not indexing anything for a Shape is not okay.  Users should get an 
> Exception and then they can decide how to proceed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to