[
https://issues.apache.org/jira/browse/LUCENE-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455203#comment-13455203
]
Robert Muir commented on LUCENE-4384:
-------------------------------------
{quote}
rat-sources is complaining about my (svn:ignore'd) *.iml IntelliJ IDEA module
configuration files sprinkled throughout the source.
I got rat-sources to shut up by adding **/*.iml to the rat.excludes definition
in lucene/common-build.xml.
{quote}
Hmm I think i've never hit this because of using eclipse: not having .iml
files. Can you commit this exclusion?
{quote}
check-forbidden-apis fails miserably though:
{quote}
I don't know why this is happening: I thought I fixed that on LUCENE-4357 (if
you had previously compiled tools/, which is usually rarely,
then they would be checked, but normally they are not compiled). I'll see if i
can figure some way to reproduce this.
> add top-level 'ant precommit'
> -----------------------------
>
> Key: LUCENE-4384
> URL: https://issues.apache.org/jira/browse/LUCENE-4384
> Project: Lucene - Core
> Issue Type: Task
> Components: general/build
> Reporter: Robert Muir
> Attachments: LUCENE-4384.patch
>
>
> We have a lot more checks in the build:
> If we added 'ant precommit' it would make it easier to run all the
> (reasonably fast) checks beforehand... and save some typing.
> So I think we can just add precommit which is:
> * check-svn-working-copy (looks for un-added files, wrong eol-style)
> * validate (nocommit/author checks, license headers, 3rd party licenses,
> forbidden apis)
> * javadocs-lint (javadocs + missing/broken links checks)
> * test
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
