[
https://issues.apache.org/jira/browse/LUCENE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456892#comment-13456892
]
Chris Male commented on LUCENE-3997:
------------------------------------
bq. I propose, instead of using lucene-core as the location for code used by
multiple modules, that we create a (single) new module that serves this
purpose, something like lucene-shared or lucene-common (though common analyzers
already use this name...)
I actually created lucene-common that when I first refactored out the
FunctionQuery codebase. After some time it was decided (in an issue I can't
remember) that the code would go into lucene-core. I agree with your
assessment that we shouldn't use lucene-core as a dumping ground, but we should
get a discussion about this going.
> join module should not depend on grouping module
> ------------------------------------------------
>
> Key: LUCENE-3997
> URL: https://issues.apache.org/jira/browse/LUCENE-3997
> Project: Lucene - Core
> Issue Type: Task
> Affects Versions: 4.0-ALPHA
> Reporter: Robert Muir
> Fix For: 4.1
>
> Attachments: LUCENE-3997.patch, LUCENE-3997.patch
>
>
> I think TopGroups/GroupDocs should simply be in core?
> Both grouping and join modules use these trivial classes, but join depends on
> grouping just for them.
> I think its better that we try to minimize these inter-module dependencies.
> Of course, another option is to combine grouping and join into one module, but
> last time i brought that up nobody could agree on a name.
> Anyway I think the change is pretty clean: its similar to having basic stuff
> like Analyzer.java in core,
> so other things can work with Analyzer without depending on any specific
> implementing modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
