Well, no code matching the pattern is in SolrCore. Here's the diff:
--- solr/src/java/org/apache/solr/core/SolrCore.java (revision 965937)
+++ solr/src/java/org/apache/solr/core/SolrCore.java (revision 965938)
@@ -690,17 +690,17 @@
SolrException.log(log, e);
}
try {
- closeSearcher();
+ updateHandler.close();
} catch (Exception e) {
SolrException.log(log,e);
}
try {
- searcherExecutor.shutdown();
+ closeSearcher();
} catch (Exception e) {
SolrException.log(log,e);
}
try {
- updateHandler.close();
+ searcherExecutor.shutdown();
} catch (Exception e) {
SolrException.log(log,e);
}
I can't find anything with three trys in a row like this, so one assumes that
subsequent changes refactored this.
Do you have evidence this is still a problem?
Best
Erick
On Thu, Sep 20, 2012 at 12:41 AM, Yandong Yao (JIRA) <[email protected]> wrote:
>
> [
> https://issues.apache.org/jira/browse/SOLR-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459331#comment-13459331
> ]
>
> Yandong Yao commented on SOLR-2008:
> -----------------------------------
>
> Just compared solr-4.0-beta source code and diff at
> http://mail-archives.apache.org/mod_mbox/lucene-commits/201007.mbox/%[email protected]%3E,
>
> seems the fix in this patch are not in solr-4.0-beta. Please help to check,
> thanks!
>
>> SolrCore.close should shutdown updateHandler before searchExecutor
>> ------------------------------------------------------------------
>>
>> Key: SOLR-2008
>> URL: https://issues.apache.org/jira/browse/SOLR-2008
>> Project: Solr
>> Issue Type: Bug
>> Affects Versions: 1.3, 1.4, 1.4.1
>> Reporter: Hoss Man
>> Assignee: Hoss Man
>> Fix For: 3.1, 4.0-ALPHA
>>
>>
>> As noted on the mailing list...
>> http://markmail.org/message/cvihm2m6aqhrfbo5
>> a RejectedExecutionException can occur when shutting down a solr core if the
>> UpdateHandler.close() wants to do an autocommit - because the searchExecutor
>> has already been closed.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
