[
https://issues.apache.org/jira/browse/SOLR-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462279#comment-13462279
]
Hoss Man commented on SOLR-3878:
--------------------------------
Jan: i've only skimmed the patch, but would it be better/simpler if
CurrencyValue.parse(...) always returned a non null CurrencyValue object, but
that CurrencyValue.getAmmount() could return null (ie: make it return Long
instead of long)?
that seems like it would simply some of the null checks you had to add in your
patch.
either way:
* CurrencyValue.parse should have some javadocs talking about how it deals with
"\*" as input
* other uses of CurrencyValue.parse need to be checked to ensure the behavior
appropriately if "\*" is specified as a value (ie: will i get a meaningful
error if I try to add a document with a value of "*" ? what happens if i do a
query on {{currency_field:\*}}
> NPE in CurrencyValue.parse() while issuing wildcard range query on a
> CurrencyField
> ----------------------------------------------------------------------------------
>
> Key: SOLR-3878
> URL: https://issues.apache.org/jira/browse/SOLR-3878
> Project: Solr
> Issue Type: Bug
> Components: query parsers
> Affects Versions: 3.6.1, 4.0-BETA
> Reporter: Miklós Márton
> Assignee: Jan Høydahl
> Priority: Critical
> Fix For: 4.0, 4.1, 5.0
>
> Attachments: SOLR-3878.patch
>
>
> According to the [wiki|http://wiki.apache.org/solr/CurrencyField#Querying]
> wildcard range queries are supported. In reality either of the following
> queries result in NPE using the example schema.
> - price_c:[* TO 1000]
> - price_c:[* TO 1000,USD]
> - price_c:[*,USD TO 1000,USD]
> - price_c:[1000 TO *]
> - price_c:[1000,USD TO *]
> - price_c:[1000,USD TO *]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
