[ https://issues.apache.org/jira/browse/LUCENE-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462708#comment-13462708 ]
Robert Muir commented on LUCENE-4423: ------------------------------------- Its also possible to add a test for this issue: we could do it either in AssertingCodec or AssertingAtomicReader, have it copy the bytes to a new byte[] { "BOGUS" + <original> } and set the offset/length. This way we know if any visitors are broken. (even though the current offset and length are superfluous imo, we should ensure visitors respect the contract). > DocumentStoredFieldVisitor.binaryField ignores offset and length > ---------------------------------------------------------------- > > Key: LUCENE-4423 > URL: https://issues.apache.org/jira/browse/LUCENE-4423 > Project: Lucene - Core > Issue Type: Bug > Components: core/store > Reporter: Adrien Grand > Attachments: LUCENE-4423.patch, LUCENE-4423.patch > > > This is no problem with SimpleText and Lucene40 since in their cases, offset > is always 0 and length the length of the byte[] array, but it might break > with custom codecs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org