[ 
https://issues.apache.org/jira/browse/SOLR-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464151#comment-13464151
 ] 

Uwe Schindler commented on SOLR-3895:
-------------------------------------

bq. But this lead me to discover that SYSTEM entities in the xsl docs 
(aparently) aren't being ignored, so with the patch attached (trying to refer 
to a bogs file fro mthe XSL) you get a stylesheet compilation error – so i 
think maybe there is still a code path missing the use of your new 
EmptyEntityResolver?

The XSL stylesheets are loaded by SolrResourceLoader like config files,... All 
those files use external entities (and SolrResourceLoader has an own 
EntityResolver to support xinclude and external entities -> it resolves 
external entities and xincludes using ResourceLoader, too) -> different story. 
This patch is about disabling entities for loaded documents, not for config 
files like solrconfig.xml, schema.xml or the transformation.
                
> For several reasons, disabling the resolving of external entities within the 
> Solr UpdateRequestHandler for XML would be good.
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-3895
>                 URL: https://issues.apache.org/jira/browse/SOLR-3895
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 3.6.1, 4.0-BETA
>            Reporter: Martin Herfurt
>            Assignee: Uwe Schindler
>            Priority: Minor
>             Fix For: 4.1, 5.0
>
>         Attachments: SOLR-3895.patch, SOLR-3895.patch, SOLR-3895.patch
>
>
> The Solr UpdateRequestHandler for XML currently resolves so-called XML 
> External Entities. Not resolving XML External Entities would - among other 
> things - improve Solr's update performance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to