David Smiley created SOLR-3913:
----------------------------------

             Summary: SimplePostTool optimize does a redundant commit
                 Key: SOLR-3913
                 URL: https://issues.apache.org/jira/browse/SOLR-3913
             Project: Solr
          Issue Type: Improvement
          Components: scripts and tools
            Reporter: David Smiley
            Priority: Minor


At the end of SimplePostTool.execute() there is:
{code}
    if (commit)   commit();
    if (optimize) optimize();
{code}
Each of these calls involves a separate request to Solr.  The thing is, an 
optimize internally commits, and so the logic should forgo committing is 
optimize is true.

And as an aside, I think the 1kb pipe() buffer on line 893 is too small; it 
should be around 8kb (8192) bytes which is the same value as 
BufferedInputStream's default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to