[ 
https://issues.apache.org/jira/browse/SOLR-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471116#comment-13471116
 ] 

Yonik Seeley commented on SOLR-3916:
------------------------------------

bq. If you look at the patch, you can see my point quite easily: when parsing 
the fl, ReturnFields is naively only treating the ' ' character as whitespace 
and not recognizing any other whitespace characters that might exist between 
field names.

I had looked at the patch, and still didn't consider not checking for other 
types of whitespace between fieldnames a bug since we never promised to support 
that.  If you look at the code that was used before ReturnFields, it also used 
a pattern that only split on comma or space.  The previous code did handle 
leading/trailing whitespace via using String.trim() first though.

                
> fl parsing is sensitive to newlines at the end of field names
> -------------------------------------------------------------
>
>                 Key: SOLR-3916
>                 URL: https://issues.apache.org/jira/browse/SOLR-3916
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.0-BETA
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>             Fix For: 4.0, 4.1, 5.0
>
>         Attachments: SOLR-3916.patch
>
>
> As reported by giovanni.bricconi on the user list, there is a bug in "fl" 
> parsing that causes solr to get confused when a field name is followed by a 
> newline character -- eg: in a requestHandler default like...
> {noformat}
> <!-- newlines showing using "$" -->$
> <str name="fl">$
>    sku,store_slug$  
> </str>$
> {noformat}
> ...this results in solr assuming it should use function parsing to evaluate 
> the field name, which can cause missleading errors if the field name can't be 
> used in a function (eg: "can not use FieldCache on multivalued field: 
> store_slug")

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to