[
https://issues.apache.org/jira/browse/LUCENE-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483418#comment-13483418
]
Ryan McKinley commented on LUCENE-4494:
---------------------------------------
Your patch looks good as is. With the tests and docs you have, I expect it
will easily slide into commons codec.
re 'codecs are rarely touched'
I expect they do not *change* them often (ever?), but adding a new generally
useful codec is what the project is for!
Nothing in the patch relies on lucene -- I suggest making a patch just like
this one and posting it here:
https://issues.apache.org/jira/browse/CODEC
Just take what you have and replace:
{code}lucene/analysis/phonetic/src/test/org/apache/lucene/analysis/phonetic/{code}
with
{code}src/main/java/org/apache/commons/codec/language/{code}
and you should be good.
Let me know if you need help
> Add phoenetic algorithm Match Rating approach to lucene
> -------------------------------------------------------
>
> Key: LUCENE-4494
> URL: https://issues.apache.org/jira/browse/LUCENE-4494
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 4.0-ALPHA
> Reporter: Colm Rice
> Priority: Minor
> Fix For: 4.1
>
> Attachments: LUCENE-4494.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project.
> What I have at the moment is a class called
> org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing
> StringEncoder
> I have a pretty comprehensive test file located at:
> org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here.
> Thanks! Feel free to email.
> FYI: It my first contribitution so be gentle :-) C# is my native.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
