[
https://issues.apache.org/jira/browse/SOLR-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Dyer updated SOLR-4051:
-----------------------------
Attachment: SOLR-4051.patch
This also fixes SOLR-1970 & SOLR-2658, allowing configurable locale,
dateformat, filename and location. It needs a new test and validation.
This adds a <propertyWriter /> as an element in data-config.xml that allows the
user to specify an implementation of interface DIHPropertiesWriter. This
interface was introduced in 3.6 and should have been marked as
"lucene.experimental". This patch changes this interface and adds the
experimental annotation also, just in case it needs to change again.
Allowing pluggable property writers should open the door to easily solve issues
like SOLR-3365.
> DIH Delta updates do not work for all locales
> ---------------------------------------------
>
> Key: SOLR-4051
> URL: https://issues.apache.org/jira/browse/SOLR-4051
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 4.0
> Reporter: James Dyer
> Priority: Minor
> Attachments: SOLR-4051.patch
>
>
> DIH Writes the last modified date to a Properties file using the default
> locale. This gets sent in plaintext to the database at the next delta
> update. DIH does not use prepared statements but just puts the date in an
> SQL Statement in yyyy-mm-dd hh:mm:ss format. It would probably be best to
> always format this date in JDBC escape syntax
> (http://docs.oracle.com/javase/1.4.2/docs/guide/jdbc/getstart/statement.html#999472)
> and java.sql.Timestamp#toString(). To do this, we'd need to parse the
> user's query and remove the single quotes likely there (and now the quotes
> would be optional and undesired).
> It might just be simpler to change the SimpleDateFormat to use the root
> locale as this appears to be the original intent here anyhow. Affected
> locales include ja_JP_JP , hi_IN , th_TH
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
