I committed a fix ... the test wasn't tie-breaking like the actual suggester.
Mike McCandless http://blog.mikemccandless.com On Sat, Nov 10, 2012 at 9:39 AM, Simon Willnauer <[email protected]> wrote: > On Sat, Nov 10, 2012 at 3:19 PM, Robert Muir <[email protected]> wrote: >> I'm confused how this test is safe when preserveSep=true (which it is >> with this failing seed). >> >> its a twist on the original top-N test, testing all prefixes of every >> word in the dictionary against a "SlowCompletor" impl: >> >> for (int j = 1; j < key.length(); j++) { >> allPrefixes.add(key.substring(0, j)); >> } >> >> But does SlowCompletor really correctly mimic the desired behavior of >> preserveSep=true when the input is on a token boundary here? > > maybe we should use the comparator from the fuzzy test. it usese the > automaton... > > simon >> >> On Sat, Nov 10, 2012 at 9:04 AM, Robert Muir <[email protected]> wrote: >>> I can reproduce this! >>> >>> On Fri, Nov 9, 2012 at 11:48 PM, Policeman Jenkins Server >>> <[email protected]> wrote: >>>> Build: http://jenkins.sd-datasolutions.de/job/Lucene-Solr-4.x-Linux/2313/ >>>> Java: 32bit/jdk1.7.0_09 -server -XX:+UseG1GC >>>> >>>> 1 tests failed. >>>> REGRESSION: >>>> org.apache.lucene.search.suggest.analyzing.AnalyzingSuggesterTest.testRandom >>>> >>>> Error Message: >>>> expected:<kr[ eawezmvdu obcpzy]> but was:<kr[x]> >>>> >>>> Stack Trace: >>>> org.junit.ComparisonFailure: expected:<kr[ eawezmvdu obcpzy]> but >>>> was:<kr[x]> >>>> at >>>> __randomizedtesting.SeedInfo.seed([64C9D03229E9A923:1685F53D98891F50]:0) >>>> at org.junit.Assert.assertEquals(Assert.java:125) >>>> at org.junit.Assert.assertEquals(Assert.java:147) >>>> at >>>> org.apache.lucene.search.suggest.analyzing.AnalyzingSuggesterTest.testRandom(AnalyzingSuggesterTest.java:710) >>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>>> at >>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) >>>> at >>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>> at java.lang.reflect.Method.invoke(Method.java:601) >>>> at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1559) >>>> at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner.access$600(RandomizedRunner.java:79) >>>> at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:737) >>>> at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:773) >>>> at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:787) >>>> at >>>> org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:50) >>>> at >>>> org.apache.lucene.util.TestRuleFieldCacheSanity$1.evaluate(TestRuleFieldCacheSanity.java:51) >>>> at >>>> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45) >>>> at >>>> com.carrotsearch.randomizedtesting.rules.SystemPropertiesInvariantRule$1.evaluate(SystemPropertiesInvariantRule.java:55) >>>> at >>>> org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48) >>>> at >>>> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:70) >>>> at >>>> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:48) >>>> at >>>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >>>> at >>>> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:358) >>>> at >>>> com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:782) >>>> at >>>> com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:442) >>>> at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:746) >>>> at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$3.evaluate(RandomizedRunner.java:648) >>>> at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$4.evaluate(RandomizedRunner.java:682) >>>> at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:693) >>>> at >>>> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45) >>>> at >>>> org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:42) >>>> at >>>> com.carrotsearch.randomizedtesting.rules.SystemPropertiesInvariantRule$1.evaluate(SystemPropertiesInvariantRule.java:55) >>>> at >>>> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39) >>>> at >>>> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39) >>>> at >>>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >>>> at >>>> org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:43) >>>> at >>>> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:48) >>>> at >>>> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:70) >>>> at >>>> org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:55) >>>> at >>>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >>>> at >>>> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:358) >>>> at java.lang.Thread.run(Thread.java:722) >>>> >>>> >>>> >>>> >>>> Build Log: >>>> [...truncated 7796 lines...] >>>> [junit4:junit4] Suite: >>>> org.apache.lucene.search.suggest.analyzing.AnalyzingSuggesterTest >>>> [junit4:junit4] 2> NOTE: reproduce with: ant test >>>> -Dtestcase=AnalyzingSuggesterTest -Dtests.method=testRandom >>>> -Dtests.seed=64C9D03229E9A923 -Dtests.multiplier=3 -Dtests.slow=true >>>> -Dtests.locale=hi_IN -Dtests.timezone=Pacific/Norfolk >>>> -Dtests.file.encoding=US-ASCII >>>> [junit4:junit4] FAILURE 4.47s J0 | AnalyzingSuggesterTest.testRandom <<< >>>> [junit4:junit4] > Throwable #1: org.junit.ComparisonFailure: >>>> expected:<kr[ eawezmvdu obcpzy]> but was:<kr[x]> >>>> [junit4:junit4] > at >>>> __randomizedtesting.SeedInfo.seed([64C9D03229E9A923:1685F53D98891F50]:0) >>>> [junit4:junit4] > at org.junit.Assert.assertEquals(Assert.java:125) >>>> [junit4:junit4] > at org.junit.Assert.assertEquals(Assert.java:147) >>>> [junit4:junit4] > at >>>> org.apache.lucene.search.suggest.analyzing.AnalyzingSuggesterTest.testRandom(AnalyzingSuggesterTest.java:710) >>>> [junit4:junit4] > at >>>> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>>> [junit4:junit4] > at >>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) >>>> [junit4:junit4] > at >>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>> [junit4:junit4] > at java.lang.reflect.Method.invoke(Method.java:601) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1559) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner.access$600(RandomizedRunner.java:79) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:737) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:773) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:787) >>>> [junit4:junit4] > at >>>> org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:50) >>>> [junit4:junit4] > at >>>> org.apache.lucene.util.TestRuleFieldCacheSanity$1.evaluate(TestRuleFieldCacheSanity.java:51) >>>> [junit4:junit4] > at >>>> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.rules.SystemPropertiesInvariantRule$1.evaluate(SystemPropertiesInvariantRule.java:55) >>>> [junit4:junit4] > at >>>> org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48) >>>> [junit4:junit4] > at >>>> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:70) >>>> [junit4:junit4] > at >>>> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:48) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:358) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:782) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:442) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:746) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$3.evaluate(RandomizedRunner.java:648) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$4.evaluate(RandomizedRunner.java:682) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:693) >>>> [junit4:junit4] > at >>>> org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45) >>>> [junit4:junit4] > at >>>> org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:42) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.rules.SystemPropertiesInvariantRule$1.evaluate(SystemPropertiesInvariantRule.java:55) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >>>> [junit4:junit4] > at >>>> org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:43) >>>> [junit4:junit4] > at >>>> org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:48) >>>> [junit4:junit4] > at >>>> org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:70) >>>> [junit4:junit4] > at >>>> org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:55) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36) >>>> [junit4:junit4] > at >>>> com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:358) >>>> [junit4:junit4] > at java.lang.Thread.run(Thread.java:722) >>>> [junit4:junit4] 2> NOTE: test params are: codec=Lucene41: {}, >>>> sim=RandomSimilarityProvider(queryNorm=false,coord=no): {}, locale=hi_IN, >>>> timezone=Pacific/Norfolk >>>> [junit4:junit4] 2> NOTE: Linux 3.2.0-32-generic i386/Oracle Corporation >>>> 1.7.0_09 (32-bit)/cpus=8,threads=1,free=38580880,total=67108864 >>>> [junit4:junit4] 2> NOTE: All tests run in this JVM: [WFSTCompletionTest, >>>> TestJaroWinklerDistance, TestLuceneDictionary, AnalyzingSuggesterTest] >>>> [junit4:junit4] Completed on J0 in 4.69s, 16 tests, 1 failure <<< FAILURES! >>>> >>>> [...truncated 57 lines...] >>>> BUILD FAILED >>>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/build.xml:337: The >>>> following error occurred while executing this line: >>>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/build.xml:39: The >>>> following error occurred while executing this line: >>>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/lucene/build.xml:519: The >>>> following error occurred while executing this line: >>>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/lucene/common-build.xml:1691: >>>> The following error occurred while executing this line: >>>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/lucene/module-build.xml:61: >>>> The following error occurred while executing this line: >>>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/lucene/common-build.xml:1163: >>>> The following error occurred while executing this line: >>>> /mnt/ssd/jenkins/workspace/Lucene-Solr-4.x-Linux/lucene/common-build.xml:827: >>>> There were test failures: 19 suites, 89 tests, 1 failure, 1 ignored (1 >>>> assumption) >>>> >>>> Total time: 16 minutes 18 seconds >>>> Build step 'Invoke Ant' marked build as failure >>>> Archiving artifacts >>>> Recording test results >>>> Description set: Java: 32bit/jdk1.7.0_09 -server -XX:+UseG1GC >>>> Email was triggered for: Failure >>>> Sending email for trigger: Failure >>>> >>>> >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
