[
https://issues.apache.org/jira/browse/LUCENE-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated LUCENE-4489:
-----------------------------
Attachment: LUCENE-4489.patch
Thanks rob,
bq. (I changed the loop to 1..limit).
...i could not for the life of me make sense of this and how the existing test
worked at all, until i realized it wasn't realy testing anything about the
filter -- was using 10^3 in one place and 10^4 in another -- so the limit never
even got hit.
I've updated the patch to add this as an option in the factory, and include
some docs explaining the trade off in using the new option and what the default
is.
(would appreciate sanity check of the wording in the javadocs)
> improve LimitTokenCountFilter and/or it's tests
> -----------------------------------------------
>
> Key: LUCENE-4489
> URL: https://issues.apache.org/jira/browse/LUCENE-4489
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: LUCENE-4489.patch, LUCENE-4489.patch, LUCENE-4489.patch,
> LUCENE-4489.patch
>
>
> spinning off a discussion about LimitTokenCountFilter and it's tests from
> SOLR-3961 (which was about a specific bug in the LimitTokenCountFilterFactory)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
